Address gcc warnings

include/jitmap/query/expr.h

@@ -19,6 +19,8 @@
 #include <utility>
 #include <vector>
 
+#include <jitmap/util/exception.h>
+
 namespace jitmap {
 namespace query {
 
@@ -205,6 +207,8 @@ auto Expr::Visit(Visitor&& v) const {
  case XOR_OPERATOR:
  return v(dynamic_cast<const XorOpExpr*>(this));
  }
+
+ throw Exception("Unknown type: ", type());
 }
 
 template <typename Visitor>
@@ -225,6 +229,8 @@ auto Expr::Visit(Visitor&& v) {
  case XOR_OPERATOR:
  return v(dynamic_cast<XorOpExpr*>(this));
  }
+
+ throw Exception("Unknown type: ", type());
 }
 
 std::ostream& operator<<(std::ostream& os, const Expr& e);

include/jitmap/util/compiler.h

@@ -0,0 +1,16 @@
+// Copyright 2020 RStudio, Inc. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http:https://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+#pragma once
+
+#define JITMAP_UNUSED(e) (void)(e);

src/jitmap/query/expr.cc

@@ -19,6 +19,7 @@
 
 #include "jitmap/query/matcher.h"
 #include "jitmap/query/type_traits.h"
+#include "jitmap/util/compiler.h"
 
 namespace jitmap {
 namespace query {
@@ -72,6 +73,10 @@ bool Expr::operator==(const Expr& rhs) const {
  using E = std::decay_t<std::remove_pointer_t<decltype(left)>>;
  const E* right = static_cast<const E*>(&rhs);
 
+ // GCC warns about unused `right`. This is due to the conditional constexpr
+ // in the literal case.
+ JITMAP_UNUSED(right);
+
  if constexpr (is_literal<E>::value) return true;
  if constexpr (is_variable<E>::value) return left->value() == right->value();
  if constexpr (is_unary_op<E>::value) return *left->operand() == *right->operand();
@@ -102,6 +107,8 @@ static const char* OpToChar(Expr::Type op) {
  case Expr::XOR_OPERATOR:
  return "^";
  }
+
+ throw Exception("Unkonwn operator type: ", op);
 }
 
 std::string Expr::ToString() const {

src/jitmap/query/matcher.cc

@@ -76,6 +76,8 @@ bool ChainMatcher::Match(const Expr& expr) const {
  case ANY:
  return std::any_of(matchers_.cbegin(), matchers_.cend(), match);
  }
+
+ throw Exception("Unknown match type: ", mode_);
 }
 
 } // namespace query

src/jitmap/query/parser.cc

@@ -46,6 +46,8 @@ const char* TokenTypeToString(Token::Type type) {
  case Token::Type::END_OF_STREAM:
  return "EOS";
  }
+
+ throw ParserException("Unkonwn token type: ", type);
 }
 
 std::ostream& operator<<(std::ostream& os, Token::Type type) {