Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Invert the left and right output for simple test cases #140

Conversation

AugustoFKL
Copy link
Contributor

Now the right side is the 'expected' one, and the left side is the 'input'. Example:

 #[test_case(2, 2 => 2 + 3)]
 fn result_which_panics(x: u32, y: u32) -> u32 {
     x + y
 }

Previously, the output was:

 Left:  5
 Right: 4

Now, it is:

 Left:  4
 Right: 5

Refs: #125

@AugustoFKL AugustoFKL marked this pull request as ready for review January 3, 2024 10:58
@AugustoFKL AugustoFKL force-pushed the invert-left-and-right-output-for-simple-test-cases branch from c091efd to 5377246 Compare January 3, 2024 11:19
Copy link
Owner

@frondeus frondeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@luke-biel

@AugustoFKL AugustoFKL force-pushed the invert-left-and-right-output-for-simple-test-cases branch from 5377246 to 110f52c Compare January 5, 2024 02:06
@AugustoFKL
Copy link
Contributor Author

@luke-biel @frondeus adjusted the nightly snapshot.

@luke-biel
Copy link
Collaborator

Those are rather minor bs fails. There's a script ./scrits/test_all.sh that you can use to run all of this locally (just make sure to run rustup update before, to be against latest nightly / stable)

Now the right side is the 'expected' one, and the left side is the 'input'. Example:

```rust
 #[test_case(2, 2 => 2 + 3)]
 fn result_which_panics(x: u32, y: u32) -> u32 {
     x + y
 }
```

Previously, the output was:

```
 Left:  5
 Right: 4
```

Now, it is:

```
 Left:  4
 Right: 5
```

Refs: frondeus#125
@AugustoFKL AugustoFKL force-pushed the invert-left-and-right-output-for-simple-test-cases branch from 110f52c to 552b613 Compare January 5, 2024 17:51
@AugustoFKL
Copy link
Contributor Author

@frondeus, thank you for the help!

Fixed and validated, the script is running fine.

@luke-biel luke-biel merged commit 39526d4 into frondeus:master Jan 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants