Separate parsing utils into new test-case-utils crate #114
Conversation
| @@ -23,7 +23,7 @@ doctest = false | |||
| path = "src/lib.rs" | |||
|
|
|||
| [dependencies] | |||
| test-case-macros = { version = "2.2.1", path = "crates/test-case-macros", default-features = false } | |||
| test-case-macros = { version = "2.2.2", path = "crates/test-case-macros", default-features = false } | |||
There was a problem hiding this comment.
Seemed this bump was just missing, but lmk if I am missing something
There was a problem hiding this comment.
That's odd, coz on crates.io we definitely have correct one released
evforde
force-pushed
the
test-case-utils
branch
from
7ef9e5f
to
9b0e50c
Compare
| @@ -10,7 +10,6 @@ readme = "../../README.md" | |||
| license = "MIT" | |||
| repository = "https://github.com/frondeus/test-case" | |||
| documentation = "https://docs.rs/test-case" | |||
| exclude = ["tests/snapshots/**/*"] | |||
There was a problem hiding this comment.
I think this was from copy-pasting the root Cargo.toml, but again lmk if missing something :)
crates/test-case-utils/Cargo.toml
Outdated
| version = "2.2.2" | ||
| edition = "2018" | ||
| authors = ["Marcin Sas-Szymanski <[email protected]>", "Wojciech Polak <[email protected]>", "Łukasz Biel <[email protected]>"] | ||
| description = "Provides utils for parsing #[test_case(...)] procedural macro attribute for generating parametrized test cases easily" |
There was a problem hiding this comment.
Feel free to tweak this - this Cargo.toml is mostly copy-paste from the old test-case-macros/Cargo.toml with a different description and dropping the proc-macro = true
|
Took a small stab at this, let me know what you think @luke-biel 🙂 |
|
It looks fine. If you run rustfmt on it and all tests pass we can merge it @evforde :) I'm gonna look into that 1.49 tests fail. If they keep on acting up, we'll just drop them. As much as I hate it, in order to keep maintaining this crate we'll probably have to make looser MSRV and validation policy. |
|
I had to push changes which you partialy did in order to preserve CI green-ness, hope it's not too problematic to rebase your PR with new master. |
Rename test-case-utils to test-case-core Fix clippy Actually fix clippy
evforde
force-pushed
the
test-case-utils
branch
from
de30dcf
to
7656436
Compare
|
Nice! Thanks for doing the surgery out of my pay grade @luke-biel, appreciate all the support :) Rebased no problem - can you approve the workflows to kick of CI once more before I merge? |
|
Ok, this time I feel good 😆 ran CI locally. One more workflow kick off? @luke-biel |
|
Merged. I'm gonna release it today evening @evforde |
Addresses #113
Since proc macro crates cannot publicly expose anything other than procedural macros, all utils for parsing
#[test_case(...)]attributes aren't able to be made public.This now allows other devs to use some of the parsing utils currently used by the
test_caseattribute