Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hallo
i try to use jenn to create a set of 3D models. i modified the code a little to generate low polygon models.
by proofing the result i detect some possible little improvements:
(i don't fix this now, but i think to separate the vertex draw from the edge draw would be useful. and to use a hashset (std::set) for a double cleaned list to draw the edges.)
the only thing i get done to fix partially:
i could fix the edges surrounding the geometry but not 100%, and not this ones which point to the center.
(i used a dirty hack to suppress the automatic polygon smoothing algo, and forced a 3 geometry shape for the tubes, to check the orientation of the edge tubes.)
if jenn would support this, it would be possible to reduce the polygon count and increase so the speed, specially for the very complex structures. if the symmetry of the geometry fits, less polygon resolution would still look nice and correct. (but this is maybe not a easy thing to fix)
for now i was not able to fix what i detect. i will try to see if i am able to improve the geometry.
don't know it this is from any interest here, because the improvements are only visible in low polygon geometry and are perfectionistic and not bugs.
pleas don't see this as criticism, because the program is great.