Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[twitter] Add support for unretweet and post/comment deletion #1211

Merged

Conversation

MrPetovan
Copy link
Collaborator

Closes friendica/friendica#11022

Also:

  • Improve probe_detect hook function
  • Add item_by_link hook function

Remaining caveat: Comments posted on Twitter and imported in Friendica do not trigger any Notifier task, possibly because they are private to the user and don't require any remote deletion notifications sent. Comments posted on Friendica and mirrored on Twitter trigger the Notifier task and the Twitter counter-part will be deleted accordingly.

Depends on friendica/friendica#11025 for the hook part.

- Prevent tweet URLs to be considered as contact URLs
Remaining caveat: Comments posted on Twitter and imported in Friendica do not trigger any Notifier task, possibly because they are private to the user and don't require any remote deletion notifications sent. Comments posted on Friendica and mirrored on Twitter trigger the Notifier task and the Twitter counter-part will be deleted accordingly.
@MrPetovan
Copy link
Collaborator Author

@annando Some checks don't seem to make sense in twitter_post_hook, like the checks on the pconfig twitter.import value in a hook meant to post data to Twitter. On the contrary we don't check the pcfonfig twitter.post value in the same hook function even though it is meant to control posting to Twitter.

@nupplaphil
Copy link
Collaborator

@MrPetovan shall I wait for @annando 's Feedback

@annando
Copy link
Collaborator

annando commented Nov 27, 2021

That check for "import" is meant for the special handling of imported Twitter posts, I guess. So when we are not importing Tweets then we are stopping here. You can see here the origin: https://github.com/friendica/friendica-addons/pull/157/files

@MrPetovan
Copy link
Collaborator Author

Why are we stopping a process meant to export content to Twitter with the import config?

@MrPetovan
Copy link
Collaborator Author

@MrPetovan shall I wait for @annando 's Feedback

No, my question is tangential to the original task.

@nupplaphil nupplaphil merged commit 13ce3aa into friendica:develop Nov 27, 2021
@MrPetovan MrPetovan deleted the task/11022-twitter-support-delete branch November 27, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants