Skip to content

Commit

Permalink
Remove no-longer-necessary LTO checks from keyboards' config.h files (q…
Browse files Browse the repository at this point in the history
…mk#8773)

* Remove no-longer-necessary LTO checks from keyboards' config.h files

* Remove unnecessary LTO check in @danielo515's Ergodox EZ keymap

* Remove unnecessary USE_Link_Time_Optimization checks from keyboards' config.h files

Note: DISABLE_LEADER doesn't seem to be used anywhere
  • Loading branch information
vomindoraan authored Apr 19, 2020
1 parent 33bf486 commit 2d39a9d
Show file tree
Hide file tree
Showing 45 changed files with 116 additions and 197 deletions.
7 changes: 3 additions & 4 deletions keyboards/abacus/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,9 @@ along with this program. If not, see <https://www.gnu.org/licenses/>.
//#define NO_ACTION_ONESHOT

/* disable these deprecated features by default */
#ifndef LINK_TIME_OPTIMIZATION_ENABLE
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION
#endif
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION

/*
* MIDI options
*/
Expand Down
6 changes: 2 additions & 4 deletions keyboards/ai03/orbit_x/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,8 @@ along with this program. If not, see <https://www.gnu.org/licenses/>.
//#define NO_ACTION_ONESHOT

/* disable these deprecated features by default */
#ifndef LINK_TIME_OPTIMIZATION_ENABLE
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION
#endif
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION

/* Bootmagic Lite key configuration */
// #define BOOTMAGIC_LITE_ROW 0
Expand Down
7 changes: 3 additions & 4 deletions keyboards/allison/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,9 @@ along with this program. If not, see <https://www.gnu.org/licenses/>.
//#define NO_ACTION_ONESHOT

/* disable these deprecated features by default */
#ifndef LINK_TIME_OPTIMIZATION_ENABLE
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION
#endif
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION

/*
* MIDI options
*/
Expand Down
7 changes: 3 additions & 4 deletions keyboards/allison_numpad/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,9 @@ along with this program. If not, see <https://www.gnu.org/licenses/>.
//#define NO_ACTION_ONESHOT

/* disable these deprecated features by default */
#ifndef LINK_TIME_OPTIMIZATION_ENABLE
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION
#endif
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION

/*
* MIDI options
*/
Expand Down
7 changes: 3 additions & 4 deletions keyboards/bat43/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,9 @@ along with this program. If not, see <https://www.gnu.org/licenses/>.
//#define NO_ACTION_ONESHOT

/* disable these deprecated features by default */
#ifndef LINK_TIME_OPTIMIZATION_ENABLE
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION
#endif
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION

/*
* MIDI options
*/
Expand Down
7 changes: 3 additions & 4 deletions keyboards/ckeys/washington/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -193,10 +193,9 @@ along with this program. If not, see <https://www.gnu.org/licenses/>.
//#define NO_ACTION_ONESHOT

/* disable these deprecated features by default */
#ifndef LINK_TIME_OPTIMIZATION_ENABLE
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION
#endif
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION

/*
* MIDI options
*/
Expand Down
7 changes: 3 additions & 4 deletions keyboards/cospad/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -193,10 +193,9 @@ along with this program. If not, see <https://www.gnu.org/licenses/>.
//#define NO_ACTION_ONESHOT

/* disable these deprecated features by default */
#ifndef LINK_TIME_OPTIMIZATION_ENABLE
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION
#endif
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION

/*
* MIDI options
*/
Expand Down
10 changes: 2 additions & 8 deletions keyboards/crkbd/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,5 @@ along with this program. If not, see <https://www.gnu.org/licenses/>.
#define USE_I2C
#define USE_SERIAL

#ifdef USE_Link_Time_Optimization
// LTO has issues with macros (action_get_macro) and "functions" (fn_actions),
// so just disable them
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION

#define DISABLE_LEADER
#endif // USE_Link_Time_Optimization
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION
7 changes: 3 additions & 4 deletions keyboards/daisy/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,9 @@ along with this program. If not, see <https://www.gnu.org/licenses/>.
//#define NO_ACTION_ONESHOT

/* disable these deprecated features by default */
#ifndef LINK_TIME_OPTIMIZATION_ENABLE
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION
#endif
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION

/*
* MIDI options
*/
Expand Down
6 changes: 2 additions & 4 deletions keyboards/dztech/dz60rgb/v1/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,8 @@
#define DEBOUNCE 3

/* disable these deprecated features by default */
#ifndef LINK_TIME_OPTIMIZATION_ENABLE
# define NO_ACTION_MACRO
# define NO_ACTION_FUNCTION
#endif
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION

#ifdef RGB_MATRIX_ENABLE
# define RGB_DISABLE_AFTER_TIMEOUT 0 // number of ticks to wait until disabling effects
Expand Down
6 changes: 2 additions & 4 deletions keyboards/dztech/dz60rgb/v2/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,8 @@
#define DEBOUNCE 3

/* disable these deprecated features by default */
#ifndef LINK_TIME_OPTIMIZATION_ENABLE
# define NO_ACTION_MACRO
# define NO_ACTION_FUNCTION
#endif
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION

#ifdef RGB_MATRIX_ENABLE
# define RGB_DISABLE_AFTER_TIMEOUT 0 // number of ticks to wait until disabling effects
Expand Down
6 changes: 2 additions & 4 deletions keyboards/dztech/dz60rgb_ansi/v1/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,8 @@
#define DEBOUNCE 3

/* disable these deprecated features by default */
#ifndef LINK_TIME_OPTIMIZATION_ENABLE
# define NO_ACTION_MACRO
# define NO_ACTION_FUNCTION
#endif
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION

#ifdef RGB_MATRIX_ENABLE
# define RGB_DISABLE_AFTER_TIMEOUT 0 // number of ticks to wait until disabling effects
Expand Down
6 changes: 2 additions & 4 deletions keyboards/dztech/dz60rgb_ansi/v2/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,8 @@
#define DEBOUNCE 3

/* disable these deprecated features by default */
#ifndef LINK_TIME_OPTIMIZATION_ENABLE
# define NO_ACTION_MACRO
# define NO_ACTION_FUNCTION
#endif
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION

#ifdef RGB_MATRIX_ENABLE
# define RGB_DISABLE_AFTER_TIMEOUT 0 // number of ticks to wait until disabling effects
Expand Down
6 changes: 2 additions & 4 deletions keyboards/dztech/dz60rgb_wkl/v1/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,8 @@
#define DEBOUNCE 3

/* disable these deprecated features by default */
#ifndef LINK_TIME_OPTIMIZATION_ENABLE
# define NO_ACTION_MACRO
# define NO_ACTION_FUNCTION
#endif
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION

#ifdef RGB_MATRIX_ENABLE
# define RGB_DISABLE_AFTER_TIMEOUT 0 // number of ticks to wait until disabling effects
Expand Down
6 changes: 2 additions & 4 deletions keyboards/dztech/dz60rgb_wkl/v2/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,8 @@
#define DEBOUNCE 3

/* disable these deprecated features by default */
#ifndef LINK_TIME_OPTIMIZATION_ENABLE
# define NO_ACTION_MACRO
# define NO_ACTION_FUNCTION
#endif
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION

#ifdef RGB_MATRIX_ENABLE
# define RGB_DISABLE_AFTER_TIMEOUT 0 // number of ticks to wait until disabling effects
Expand Down
6 changes: 2 additions & 4 deletions keyboards/dztech/dz65rgb/v1/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,8 @@
#define DIODE_DIRECTION COL2ROW

/* disable these deprecated features by default */
#ifndef LINK_TIME_OPTIMIZATION_ENABLE
# define NO_ACTION_MACRO
# define NO_ACTION_FUNCTION
#endif
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION

#ifdef RGB_MATRIX_ENABLE
# define RGB_MATRIX_LED_PROCESS_LIMIT 4
Expand Down
6 changes: 2 additions & 4 deletions keyboards/dztech/dz65rgb/v2/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,8 @@
#define DIODE_DIRECTION COL2ROW

/* disable these deprecated features by default */
#ifndef LINK_TIME_OPTIMIZATION_ENABLE
# define NO_ACTION_MACRO
# define NO_ACTION_FUNCTION
#endif
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION

#ifdef RGB_MATRIX_ENABLE
# define RGB_MATRIX_LED_PROCESS_LIMIT 4
Expand Down
6 changes: 2 additions & 4 deletions keyboards/ergodox_ez/keymaps/danielo515/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,7 @@
# define NO_PRINT
#endif

#ifndef LINK_TIME_OPTIMIZATION_ENABLE
# define NO_ACTION_MACRO
# define NO_ACTION_FUNCTION
#endif
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION

#undef RGBLIGHT_ANIMATIONS
7 changes: 3 additions & 4 deletions keyboards/exclusive/e7v1se/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,9 @@ along with this program. If not, see <https://www.gnu.org/licenses/>.
//#define NO_ACTION_ONESHOT

/* disable these deprecated features by default */
#ifndef LINK_TIME_OPTIMIZATION_ENABLE
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION
#endif
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION

/*
* MIDI options
*/
Expand Down
9 changes: 3 additions & 6 deletions keyboards/handwired/fc200rt_qmk/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,13 @@ along with this program. If not, see <https://www.gnu.org/licenses/>.
#define MATRIX_ROWS 8
#define MATRIX_COLS 16


#define MATRIX_ROW_PINS { B0, B1, B2, B3, E6, B7, D0, D1 }
#define MATRIX_COL_PINS { D2, D3, C6, C7, D5, D4, D6, D7, B4, B5, B6, F7, F6, F5, F4, F1 }
#define UNUSED_PINS

/* COL2ROW, ROW2COL*/
#define DIODE_DIRECTION ROW2COL


/* Debounce reduces chatter (unintended double-presses) - set 0 if debouncing is not needed */
#define DEBOUNCE 5

Expand Down Expand Up @@ -130,7 +128,6 @@ along with this program. If not, see <https://www.gnu.org/licenses/>.
//#define MAGIC_KEY_NKRO N
//#define MAGIC_KEY_SLEEP_LED Z

#ifndef LINK_TIME_OPTIMIZATION_ENABLE
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION
#endif
/* disable these deprecated features by default */
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION
7 changes: 3 additions & 4 deletions keyboards/handwired/floorboard/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,9 @@ along with this program. If not, see <https://www.gnu.org/licenses/>.
//#define NO_ACTION_ONESHOT

/* disable these deprecated features by default */
#ifndef LINK_TIME_OPTIMIZATION_ENABLE
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION
#endif
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION

/*
* MIDI options
*/
Expand Down
7 changes: 3 additions & 4 deletions keyboards/handwired/jtallbean/split_65/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -195,10 +195,9 @@ along with this program. If not, see <https://www.gnu.org/licenses/>.
//#define NO_ACTION_ONESHOT

/* disable these deprecated features by default */
#ifndef LINK_TIME_OPTIMIZATION_ENABLE
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION
#endif
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION

/*
* MIDI options
*/
Expand Down
7 changes: 3 additions & 4 deletions keyboards/handwired/sick68/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -194,10 +194,9 @@ along with this program. If not, see <https://www.gnu.org/licenses/>.
//#define NO_ACTION_ONESHOT

/* disable these deprecated features by default */
#ifndef LINK_TIME_OPTIMIZATION_ENABLE
# define NO_ACTION_MACRO
# define NO_ACTION_FUNCTION
#endif
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION

/*
* MIDI options
*/
Expand Down
6 changes: 2 additions & 4 deletions keyboards/handwired/videowriter/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,8 @@ along with this program. If not, see <https://www.gnu.org/licenses/>.
//#define NO_ACTION_ONESHOT

/* disable these deprecated features by default */
#ifndef LINK_TIME_OPTIMIZATION_ENABLE
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION
#endif
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION

/* Bootmagic Lite key configuration */
// #define BOOTMAGIC_LITE_ROW 0
Expand Down
7 changes: 3 additions & 4 deletions keyboards/hineybush/physix/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,9 @@ along with this program. If not, see <https://www.gnu.org/licenses/>.
//#define NO_ACTION_ONESHOT

/* disable these deprecated features by default */
#ifndef LINK_TIME_OPTIMIZATION_ENABLE
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION
#endif
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION

/*
* MIDI options
*/
Expand Down
6 changes: 2 additions & 4 deletions keyboards/j80/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,8 @@ along with this program. If not, see <https://www.gnu.org/licenses/>.
#define BACKLIGHT_PIN D4

/* disable these deprecated features by default */
#ifndef LINK_TIME_OPTIMIZATION_ENABLE
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION
#endif
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION

/* key combination for magic key command */
/* defined by default; to change, uncomment and set to the combination you want */
Expand Down
7 changes: 3 additions & 4 deletions keyboards/jae/j01/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,9 @@ along with this program. If not, see <https://www.gnu.org/licenses/>.
//#define NO_ACTION_ONESHOT

/* disable these deprecated features by default */
#ifndef LINK_TIME_OPTIMIZATION_ENABLE
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION
#endif
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION

/*
* MIDI options
*/
Expand Down
6 changes: 2 additions & 4 deletions keyboards/just60/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,5 @@ along with this program. If not, see <https://www.gnu.org/licenses/>.
#define LOCKING_RESYNC_ENABLE

/* disable these deprecated features by default */
#ifndef LINK_TIME_OPTIMIZATION_ENABLE
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION
#endif
#define NO_ACTION_MACRO
#define NO_ACTION_FUNCTION
Loading

0 comments on commit 2d39a9d

Please sign in to comment.