Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameter naming for selectInterval in the documentation #6

Closed
munaja opened this issue Apr 9, 2022 · 1 comment
Closed

parameter naming for selectInterval in the documentation #6

munaja opened this issue Apr 9, 2022 · 1 comment

Comments

@munaja
Copy link

munaja commented Apr 9, 2022

Hi @frehaiku

First of all, thanks for the great library, it helps me alot in my project.

Here i just want to point out in the documentation (main page the repository), there is parameter named selectInterval to put the range of the years. But I can't use it in the instantiation. After I check the code, calendar.js at line 28, it uses config.interval or default value [1970, 2030]. Therefore if I use interval instead of selectInterval it works.

So I think there is some typo in the documentation. The one stated in documentation (selectInterval) is internal variable name, not the one used in the parameter (config).

Thanks

@frehaiku
Copy link
Owner

Thanks your feedback, now the documentation is updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants