Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Children of nodes are not serialized to JSON #180

Open
rudolphi opened this issue May 17, 2021 · 0 comments
Open

Children of nodes are not serialized to JSON #180

rudolphi opened this issue May 17, 2021 · 0 comments

Comments

@rudolphi
Copy link

Proposed fix in draw2d/src/shape/node/Node.js:
getPersistentAttributes: function () {
let memento = this._super()

// ...

memento.children = []
this.children.each(function (i, child) { // getChildren() misses the locator
  memento.children.push(extend(child.figure.getPersistentAttributes(), {
      // no child.figure.getName()
      child: child.figure.NAME,
      locator: child.locator.NAME,
      locatorAttr: child.locator.attr()
    }))
  })

return memento

},

// ...
setPersistentAttributes: function (memento) {
this._super(memento)

// ...

// remove all children created in the init method
//
this.resetChildren()

// and restore all children of the JSON document instead.
//
memento.children.forEach((e) => {
	let locator = eval("new " + e.locator + "()")
	if(e.locatorAttr) {
	  locator.attr(e.locatorAttr)
	}

	let child = eval("new " + e.child + "()")
	child.setPersistentAttributes(e)
	this.add(child, locator)
})

return this

}

rudolphi pushed a commit to rudolphi/draw2d that referenced this issue Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant