Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: custom fields #1428

Merged
merged 21 commits into from
Aug 4, 2023
Merged

refactor: custom fields #1428

merged 21 commits into from
Aug 4, 2023

Conversation

ssiyad
Copy link
Contributor

@ssiyad ssiyad commented Aug 2, 2023

Warning! Breaking change!

If you want to retain you data, follow these steps

  • Create custom fields in HD Ticket for every fieldname in custom fields (template)
  • Migrate data (with a script?)
  • Update site
  • About 5 doctypes will be changed and template fields will be lost
  • Add fields in template (Only fieldname is required)

@ssiyad ssiyad added enhancement New feature or request breaking-change labels Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 4.54% and project coverage change: -0.11% ⚠️

Comparison is base (83b48f4) 13.15% compared to head (7271ada) 13.05%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1428      +/-   ##
==========================================
- Coverage   13.15%   13.05%   -0.11%     
==========================================
  Files          56       56              
  Lines        1953     1977      +24     
==========================================
+ Hits          257      258       +1     
- Misses       1696     1719      +23     
Files Changed Coverage Δ
helpdesk/helpdesk/doctype/hd_ticket/api.py 0.00% <0.00%> (ø)
...elpdesk/helpdesk/doctype/hd_ticket_template/api.py 0.00% <0.00%> (ø)
...k/doctype/hd_ticket_template/hd_ticket_template.py 0.00% <0.00%> (ø)
..._ticket_template_field/hd_ticket_template_field.py 0.00% <0.00%> (ø)
helpdesk/__init__.py 100.00% <100.00%> (ø)
helpdesk/consts.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ssiyad ssiyad marked this pull request as ready for review August 4, 2023 08:57
@ssiyad ssiyad merged commit 2e5c5ed into frappe:main Aug 4, 2023
5 of 8 checks passed
@ssiyad ssiyad deleted the refactor/custom_fields branch August 4, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant