Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve customer portal view issue #1270

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Conversation

niraj2477
Copy link
Contributor

@niraj2477 niraj2477 commented Jun 14, 2023

Issue

  • The user cannot access the previously created ticket on the customer portal view. The SQL exception that occurred when loading the view was what caused this problem.

  • It was noticed that even if the fields were set for the desired column, the final query still had an additional *.

Screenshot 2023-06-14 at 3 24 37 PM

Solution

  • Add conditional check for adding filters to the final query.

Issue ticket: #1254

On the customer portal list view, tickets
created by the customer is nit visible
because of the SQL query exception.
This is has been fixed in this commit

Issue ticket: frappe#1254
@ssiyad ssiyad merged commit f262c96 into frappe:main Jun 19, 2023
@niraj2477 niraj2477 deleted the fix-portal-list-view branch August 3, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants