Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): move lists from settings to sidebar #1263

Merged
merged 3 commits into from
Jun 12, 2023

Conversation

ssiyad
Copy link
Contributor

@ssiyad ssiyad commented Jun 12, 2023

No description provided.

@ssiyad ssiyad added the enhancement New feature or request label Jun 12, 2023
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch coverage: 24.19% and project coverage change: +0.72 🎉

Comparison is base (75e655f) 12.87% compared to head (eecf1a4) 13.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1263      +/-   ##
==========================================
+ Coverage   12.87%   13.60%   +0.72%     
==========================================
  Files          52       52              
  Lines        1848     1867      +19     
==========================================
+ Hits          238      254      +16     
- Misses       1610     1613       +3     
Impacted Files Coverage Δ
...esk/doctype/hd_ticket_comment/hd_ticket_comment.py 0.00% <0.00%> (ø)
...k/doctype/hd_ticket_template/hd_ticket_template.py 0.00% <ø> (ø)
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py 22.56% <17.77%> (+0.04%) ⬆️
helpdesk/utils.py 39.13% <66.66%> (+39.13%) ⬆️
helpdesk/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ssiyad ssiyad merged commit f32026f into frappe:main Jun 12, 2023
7 of 8 checks passed
@ssiyad ssiyad deleted the feat/ui/settings_unpack branch June 12, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant