Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ux): ticket page: can not back go back if no history #1198

Merged
merged 1 commit into from
May 18, 2023

Conversation

ssiyad
Copy link
Contributor

@ssiyad ssiyad commented May 18, 2023

There is nothing to go back to if there is no history. This PR adds a check if there is a way to go back. If not, it will go to the default page

@ssiyad ssiyad added the bug-fix label May 18, 2023
@ssiyad
Copy link
Contributor Author

ssiyad commented May 18, 2023

closes #1196

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage: 35.00% and project coverage change: +0.45 🎉

Comparison is base (75e655f) 12.87% compared to head (8394152) 13.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1198      +/-   ##
==========================================
+ Coverage   12.87%   13.33%   +0.45%     
==========================================
  Files          52       52              
  Lines        1848     1852       +4     
==========================================
+ Hits          238      247       +9     
+ Misses       1610     1605       -5     
Impacted Files Coverage Δ
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py 22.92% <15.38%> (+0.40%) ⬆️
helpdesk/utils.py 35.00% <66.66%> (+35.00%) ⬆️
helpdesk/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ssiyad ssiyad merged commit 4becedd into frappe:main May 18, 2023
8 checks passed
@ssiyad ssiyad deleted the fix/ux/ticket_back_button branch May 18, 2023 13:10
kurogeek pushed a commit to kurogeek/helpdesk that referenced this pull request May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant