Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ux): stores: set a high number as pageLimit #1195

Merged
merged 1 commit into from
May 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(ux): stores: set a high number as pageLimit
This is because frappe-ui defaults to `pageLimit` 20. This is
undesirable for stores, since they need `all` entries. As a workaround,
a `pageLimit` of 99999 is used.
  • Loading branch information
ssiyad committed May 18, 2023
commit f3f6012c13299185cfb575acccfea8b17785f027
1 change: 1 addition & 0 deletions desk/src/stores/agent.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export const useAgentStore = defineStore("agent", () => {
doctype: "HD Agent",
fields: ["*"],
auto: true,
pageLength: 99999,
});

const options: ComputedRef<Array<Agent>> = computed(
Expand Down
1 change: 1 addition & 0 deletions desk/src/stores/contact.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ export const useContactStore = defineStore("contact", () => {
doctype: "Contact",
fields: ["*"],
auto: true,
pageLength: 99999,
});

const options: ComputedRef<Array<Contact>> = computed(
Expand Down
1 change: 1 addition & 0 deletions desk/src/stores/team.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export const useTeamStore = defineStore("team", () => {
const d__ = createListResource({
doctype: "HD Team",
auto: true,
pageLength: 99999,
});

const options: ComputedRef<Array<Team>> = computed(
Expand Down
1 change: 1 addition & 0 deletions desk/src/stores/ticketPriority.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export const useTicketPriorityStore = defineStore("ticketPriority", () => {
doctype: "HD Ticket Priority",
orderBy: "integer_value desc",
auto: true,
pageLength: 99999,
});

const options: ComputedRef<Array<TicketPriority>> = computed(
Expand Down
1 change: 1 addition & 0 deletions desk/src/stores/ticketType.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export const useTicketTypeStore = defineStore("ticketType", () => {
doctype: "HD Ticket Type",
fields: ["*"],
auto: true,
pageLength: 99999,
});

const options: ComputedRef<Array<TicketType>> = computed(
Expand Down