Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ticket list #1189

Merged
merged 13 commits into from
May 18, 2023
Merged

refactor: ticket list #1189

merged 13 commits into from
May 18, 2023

Conversation

ssiyad
Copy link
Contributor

@ssiyad ssiyad commented May 17, 2023

No description provided.

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.45 🎉

Comparison is base (75e655f) 12.87% compared to head (92d59e1) 13.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1189      +/-   ##
==========================================
+ Coverage   12.87%   13.33%   +0.45%     
==========================================
  Files          52       52              
  Lines        1848     1852       +4     
==========================================
+ Hits          238      247       +9     
+ Misses       1610     1605       -5     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ssiyad ssiyad marked this pull request as ready for review May 18, 2023 12:27
@ssiyad ssiyad merged commit 72e2c76 into frappe:main May 18, 2023
8 checks passed
@ssiyad ssiyad deleted the refactor/ticket_list branch May 18, 2023 12:28
@ssiyad ssiyad added the enhancement New feature or request label May 18, 2023
kurogeek pushed a commit to kurogeek/helpdesk that referenced this pull request May 25, 2023
* refactor(ui): ticket list

* feat: list manager: add `auto`

* fix: data: convert to composable

* fix: tickets: more button: change color

* fix: dropdown filters: use computed

* fix: ticket summary: cleanup

* chore: remove unused components

* fix: replace `this`

* fix: switch: add transition

* fix(ui): table items: remove vertical padding

* fix: summary: alignment

* chore: convert composable to a pinia store

* chore: re-order columns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant