Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ticket Activity doesn't exist. #1155

Merged
merged 1 commit into from
May 9, 2023

Conversation

kurogeek
Copy link
Contributor

@kurogeek kurogeek commented May 9, 2023

When clicking on TICKET HISTORY on a ticket page, there is an error saying, a table Ticket Activity doesn't exist.

This PR fix this issue. By changing tabTicket Activity to tabHD Ticket Activity.

When clicking on `TICKET HISTORY` on a ticket page, there is an error
saying, a table Ticket Activity doesn't exist.

This PR fix this issue. By changing `tabTicket Activity` to
`tabHD Ticket Activity`.
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Patch coverage: 7.69% and project coverage change: -0.06 ⚠️

Comparison is base (b0eab62) 12.86% compared to head (d332311) 12.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1155      +/-   ##
==========================================
- Coverage   12.86%   12.81%   -0.06%     
==========================================
  Files          52       52              
  Lines        1803     1811       +8     
==========================================
  Hits          232      232              
- Misses       1571     1579       +8     
Impacted Files Coverage Δ
...lpdesk/helpdesk/doctype/hd_customer/hd_customer.py 38.09% <0.00%> (-6.35%) ⬇️
...lpdesk/helpdesk/doctype/hd_settings/hd_settings.py 0.00% <0.00%> (ø)
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py 22.77% <0.00%> (ø)
helpdesk/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ssiyad
Copy link
Contributor

ssiyad commented May 9, 2023

LGTM

@ssiyad ssiyad merged commit 1973aed into frappe:main May 9, 2023
@ssiyad ssiyad added the bug-fix label May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants