Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): ticket: bulk insert #1148

Merged
merged 4 commits into from
May 4, 2023
Merged

feat(api): ticket: bulk insert #1148

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f59124f
feat(api): ticket: bulk insert
ssiyad May 3, 2023
b7a3566
fix: use `start_import` instead of `form_start_import`
ssiyad May 3, 2023
20536be
chore: make method more generic
ssiyad May 4, 2023
35a6efb
chore: move method to `extends.data_import`
ssiyad May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: use start_import instead of form_start_import 
former is a background job while latter is not
  • Loading branch information
@ssiyad
ssiyad committed May 3, 2023
commit b7a3566bd3ea1a6ab866e59b7ec622600b17821f
4 changes: 2 additions & 2 deletions helpdesk/api/ticket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import frappe
from frappe.automation.doctype.assignment_rule.assignment_rule import apply
from frappe.contacts.doctype.contact.contact import get_contact_name
from frappe.core.doctype.data_import.data_import import form_start_import
from frappe.core.doctype.data_import.data_import import start_import
from frappe.handler import upload_file
from frappe.utils import datetime
from frappe.website.utils import cleanup_page_name
Expand Down Expand Up @@ -33,7 +33,7 @@ def bulk_insert():
)

data_import_doc.save()
form_start_import(data_import_doc.name)
start_import(data_import_doc.name)

return data_import_doc

Expand Down