Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ux): customer portal: disallow empty messages #1143

Merged
merged 1 commit into from
May 1, 2023

Conversation

ssiyad
Copy link
Contributor

@ssiyad ssiyad commented May 1, 2023

closes #1136

@ssiyad ssiyad added the bug-fix label May 1, 2023
@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Patch coverage: 8.33% and project coverage change: -0.06 ⚠️

Comparison is base (b0eab62) 12.86% compared to head (3a3bfef) 12.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1143      +/-   ##
==========================================
- Coverage   12.86%   12.81%   -0.06%     
==========================================
  Files          52       52              
  Lines        1803     1811       +8     
==========================================
  Hits          232      232              
- Misses       1571     1579       +8     
Impacted Files Coverage Δ
...lpdesk/helpdesk/doctype/hd_customer/hd_customer.py 38.09% <0.00%> (-6.35%) ⬇️
...lpdesk/helpdesk/doctype/hd_settings/hd_settings.py 0.00% <0.00%> (ø)
helpdesk/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ssiyad ssiyad merged commit bc03132 into frappe:main May 1, 2023
5 of 8 checks passed
@ssiyad ssiyad deleted the fix/ux/disallow_empty_messages branch May 1, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not accept empty messages as replies
1 participant