Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: field names: hd_agent_group -> team #1106

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

ssiyad
Copy link
Contributor

@ssiyad ssiyad commented Apr 10, 2023

closes #1103

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch coverage: 22.22% and project coverage change: -0.03 ⚠️

Comparison is base (de4eb77) 12.79% compared to head (7ac3f99) 12.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1106      +/-   ##
==========================================
- Coverage   12.79%   12.76%   -0.03%     
==========================================
  Files          52       52              
  Lines        1782     1786       +4     
==========================================
  Hits          228      228              
- Misses       1554     1558       +4     
Impacted Files Coverage Δ
helpdesk/config/desktop.py 0.00% <ø> (ø)
helpdesk/config/docs.py 0.00% <0.00%> (ø)
helpdesk/helpdesk/doctype/hd_agent/hd_agent.py 0.00% <0.00%> (ø)
helpdesk/helpdesk/doctype/hd_article/hd_article.py 0.00% <ø> (ø)
...doctype/hd_article_category/hd_article_category.py 0.00% <ø> (ø)
...doctype/hd_article_feedback/hd_article_feedback.py 0.00% <ø> (ø)
...elpdesk/doctype/hd_article_item/hd_article_item.py 0.00% <ø> (ø)
..._sub_category_item/hd_article_sub_category_item.py 0.00% <ø> (ø)
...k/doctype/hd_canned_response/hd_canned_response.py 0.00% <ø> (ø)
...lpdesk/helpdesk/doctype/hd_customer/hd_customer.py 44.44% <ø> (ø)
... and 20 more

... and 40 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ssiyad ssiyad merged commit f11b71f into frappe:main Apr 11, 2023
@ssiyad ssiyad deleted the fix/team_fix_fieldnames branch April 11, 2023 11:40
@ssiyad ssiyad added the bug-fix label Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to add HD Agent Group from HD Agent
1 participant