Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): update toast ui (fetched from frappe-ui) #1048

Merged
merged 2 commits into from
Mar 13, 2023

Conversation

ssiyad
Copy link
Contributor

@ssiyad ssiyad commented Mar 12, 2023

Customised to include

  • Buttons
  • Form

@ssiyad
Copy link
Contributor Author

ssiyad commented Mar 12, 2023

Before

image

After

image

@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (8ba29ae) 11.79% compared to head (6a0ed7d) 11.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1048      +/-   ##
==========================================
- Coverage   11.79%   11.78%   -0.01%     
==========================================
  Files          51       51              
  Lines        1696     1697       +1     
==========================================
  Hits          200      200              
- Misses       1496     1497       +1     

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ssiyad ssiyad added the enhancement New feature or request label Mar 13, 2023
@ssiyad ssiyad merged commit d1c92af into frappe:main Mar 13, 2023
@ssiyad ssiyad deleted the feat/toast_update branch March 13, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant