feat(ux): config: brand favicon (#1167)

frappe · May 13, 2023 · 2b27334 · 2b27334
1 parent dc1208e
commit 2b27334
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/desk/src/stores/config.ts b/desk/src/stores/config.ts
@@ -1,6 +1,7 @@
 import { computed, ComputedRef } from "vue";
 import { defineStore } from "pinia";
 import { createResource } from "frappe-ui";
+import { useFavicon } from "@vueuse/core";
 import { useTitle } from "@vueuse/core";
 import { socket } from "@/socket";
 
@@ -15,13 +16,15 @@ export const useConfigStore = defineStore("config", () => {
 
  const config = computed(() => configRes.data || {});
  const brandLogo = computed(() => config.value.brand_logo);
+ const brandFavicon = computed(() => config.value.brand_favicon);
  const helpdeskName: ComputedRef<string> = computed(
  () => config.value.helpdesk_name || DEFAULT_TITLE
  );
  const suppressEmailToast: ComputedRef<boolean> = computed(
  () => config.value.suppress_default_email_toast ?? true
  );
 
+ useFavicon(brandFavicon);
  useTitle(helpdeskName);
 
  socket.on("helpdesk:settings-updated", () => configRes.reload());

diff --git a/helpdesk/api/config.py b/helpdesk/api/config.py
@@ -4,13 +4,15 @@
 @frappe.whitelist(allow_guest=True)
 def get_config():
  brand_logo = frappe.db.get_single_value("HD Settings", "brand_logo")
+ brand_favicon = frappe.db.get_single_value("HD Settings", "brand_favicon")
  helpdesk_name = frappe.db.get_single_value("HD Settings", "helpdesk_name")
  suppress_default_email_toast = frappe.db.get_single_value(
  "HD Settings", "suppress_default_email_toast"
  )
 
  return {
  "brand_logo": brand_logo,
+ "brand_favicon": brand_favicon,
  "helpdesk_name": helpdesk_name,
  "suppress_default_email_toast": suppress_default_email_toast,
  }