perf: avoid double local caching webhooks #23426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #23426 +/- ##
===========================================
- Coverage 62.35% 62.33% -0.02%
===========================================
Files 772 772
Lines 73987 74099 +112
Branches 6377 6377
===========================================
+ Hits 46134 46192 +58
- Misses 24230 24284 +54
Partials 3623 3623
Flags with carried forward coverage won't be shown. Click here to find out more. |
dj12djdjs
reviewed
Nov 24, 2023
ankush
approved these changes
Nov 29, 2023
mergify bot
pushed a commit
that referenced
this pull request
Nov 29, 2023
### Changes Made - remove cache in `frappe.flags` (and related comment) - use cache generator -⚠️ micro optimisation: use a variable for `frappe.flags` (cherry picked from commit 1490fc1)
ankush
added a commit
that referenced
this pull request
Nov 29, 2023
…-23426 perf: avoid double local caching webhooks (backport #23426)
mergify bot
pushed a commit
that referenced
this pull request
Dec 1, 2023
### Changes Made - remove cache in `frappe.flags` (and related comment) - use cache generator -⚠️ micro optimisation: use a variable for `frappe.flags` (cherry picked from commit 1490fc1) # Conflicts: # frappe/integrations/doctype/webhook/__init__.py # frappe/integrations/doctype/webhook/test_webhook.py
ankush
pushed a commit
that referenced
this pull request
Dec 1, 2023
- remove cache in `frappe.flags` (and related comment) - use cache generator -⚠️ micro optimisation: use a variable for `frappe.flags` (cherry picked from commit 1490fc1)
ankush
pushed a commit
that referenced
this pull request
Dec 1, 2023
- remove cache in `frappe.flags` (and related comment) - use cache generator -⚠️ micro optimisation: use a variable for `frappe.flags` (cherry picked from commit 1490fc1) Co-authored-by: Sagar Vora <[email protected]>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
# [15.4.0](v15.3.0...v15.4.0) (2023-12-05) ### Bug Fixes * add section below ([1e247f6](1e247f6)) * adding country Nepal in get_number_system country list ([#23582](#23582)) ([#23595](#23595)) ([6da8349](6da8349)) * Always evaluate Virtual Fields ([#23515](#23515)) ([#23517](#23517)) ([75db107](75db107)) * image cropper in RTL mode ([#23492](#23492)) ([#23506](#23506)) ([1db989d](1db989d)) * load languages that have capital letters ([8386c2b](8386c2b)) * **minor:** some more espresso polish ([#23484](#23484)) ([cae0fc0](cae0fc0)) * Only preload icons for desk ([c755e87](c755e87)) * prevent edit of readonly popup fields ([67a7a7f](67a7a7f)) * quicklist ([#23548](#23548)) ([#23550](#23550)) ([d34025b](d34025b)) * Reload whenever the effective language or timezone has changed. ([#22952](#22952)) ([#23602](#23602)) ([d6a3b33](d6a3b33)) * set sidebar only if not present ([#23486](#23486)) ([6d07c33](6d07c33)) * skip overriden doctypes during orphan check ([#23518](#23518)) ([#23519](#23519)) ([7ac064f](7ac064f)) * strip html the printview's key value ([#23606](#23606)) ([#23611](#23611)) ([2b5ce3a](2b5ce3a)) * translate customize form (german) ([#23497](#23497)) ([#23501](#23501)) ([b24bec6](b24bec6)) * Turn Route History read-only. ([ffbe3cb](ffbe3cb)) * **UI:** Display timestamp beside name ([cff43da](cff43da)) * Update subject display location ([1bed282](1bed282)) * Update the css ([077b963](077b963)) * use indian numbering for nepal ([#23593](#23593)) ([77ce927](77ce927)) ### Features * **Communication:** Schedule Send (backport [#23417](#23417)) ([#23494](#23494)) ([e15f159](e15f159)) * disable assigned thread notification ([#23535](#23535)) ([#23600](#23600)) ([bc9e2ce](bc9e2ce)) * Patch and Delete Request to integration utils ([#23525](#23525)) ([#23530](#23530)) ([0e9d204](0e9d204)) * Sentry support to automatically catch and report errors (opt-in) (backport [#23483](#23483)) ([#23589](#23589)) ([27feaf2](27feaf2)), closes [#23534](#23534) * set sender name in documents created from email (backport [#23554](#23554)) ([#23598](#23598)) ([e7649a1](e7649a1)) * **UI:** Add subject in timeline communication ([3114c9e](3114c9e)) ### Performance Improvements * avoid double local caching webhooks ([#23426](#23426)) ([721baa0](721baa0)) ### Reverts * Revert "refactor: OAuth flow without breaking routing convention" (#23566) ([1d75720](1d75720)), closes [#23566](#23566)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
# [14.58.0](v14.57.0...v14.58.0) (2023-12-05) ### Bug Fixes * adding country Nepal in get_number_system country list ([#23582](#23582)) ([#23594](#23594)) ([eead6ce](eead6ce)) * allow write perm by default ([#23510](#23510)) ([80ec747](80ec747)) * Always evaluate Virtual Fields ([#23515](#23515)) ([#23516](#23516)) ([33a5d46](33a5d46)) * always publish progress for bulk action ([0831259](0831259)) * bulk submit/cancel/update in background jobs ([a4e67a7](a4e67a7)) * bulk workflow action in background ([eda2144](eda2144)) * check the correct email account ([a227b26](a227b26)) * image cropper in RTL mode (backport [#23492](#23492)) ([#23505](#23505)) ([ef8d3b4](ef8d3b4)) * quicklist ([#23548](#23548)) ([#23549](#23549)) ([83830c5](83830c5)) * set sidebar only if not present ([#23487](#23487)) ([42c8b12](42c8b12)) * set status last ([6cd4fb4](6cd4fb4)) * strip html the printview's key value ([#23606](#23606)) ([#23610](#23610)) ([93069e7](93069e7)) * translate customize form (german) ([#23497](#23497)) ([00c50a6](00c50a6)) * Turn Route History read-only. (backport [#23585](#23585)) ([#23586](#23586)) ([9087951](9087951)) * **UI:** Display timestamp beside name ([f8ee19b](f8ee19b)) * Update subject display location ([1617ed3](1617ed3)) * Update the css ([da8a2a1](da8a2a1)) * use indian numbering for nepal ([#23592](#23592)) ([e35738a](e35738a)) ### Features * date filters in audit trail (backport [#22684](#22684)) ([#23513](#23513)) ([ae9455e](ae9455e)) * disable assigned thread notification (backport [#23535](#23535)) ([#23599](#23599)) ([d36e61d](d36e61d)) * link communication by email ([fcb90c1](fcb90c1)) * Patch and Delete Request to integration utils ([#23525](#23525)) ([#23531](#23531)) ([92ba2b1](92ba2b1)) * **UI:** Add subject in timeline communication ([78c61f1](78c61f1)) ### Performance Improvements * avoid double local caching webhooks ([#23426](#23426)) ([#23536](#23536)) ([8740147](8740147))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
frappe.flags(and related comment)frappe.flags