Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide value for CommunityID as readable digit-string now #37

Closed
wants to merge 2 commits into from
Closed

provide value for CommunityID as readable digit-string now #37

wants to merge 2 commits into from

Conversation

psytester
Copy link
Contributor

CommunityID is taken now from default value or dataset file in readable digit-string Format.
Benefits:

  • internal "NotOnChip" function is now working for DG18
  • The value is readable ;-)

CommunityID is taken now from default value or dataset file in readable digit-string Format.
Benefits:
- internal "NotOnChip" function is now working for DG18
- The value is readable ;-)
@frankmorgner
Copy link
Owner

Could you check this error: https://travis-ci.org/frankmorgner/vsmartcard/builds/48047723#L4619 , thanks?

helper variable added to be able to check against NotOnChip feature
@psytester
Copy link
Contributor Author

Do we have only a chicken-and-egg problem?

TravisCI logfile says:
[.....]
File "virtualsmartcard/tests/CardGenerator_test.py", line 73, in test_readDatagroups
.....
File "virtualsmartcard/CardGenerator.py", line 198, in __generate_nPA
CommunityID_Binary = binascii.unhexlify(CommunityID)
TypeError: Non-hexadecimal digit found

patch-10 is checked and will use the new unit tests in CardGenerator_test.py

patch-11 is a change in text file:
npa-example-data/Example_Dataset_Mueller_Gertrud.txt
--> it contains now an integer value and not longer a hexadecimal string

As long as both patches are not put together it will fail on TravisCI
But in my system the code is working...

I will never apply pull requests without GitHub Client as Webpage produces several commits. one for each file change :-(

@psytester
Copy link
Contributor Author

closed as patch-10 and patch-12 are merged into patch-11 for a single pull request.

@psytester psytester closed this Jan 23, 2015
@psytester psytester deleted the patch-10 branch January 23, 2015 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants