Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added more data and infos to Dataset file #31

Closed
wants to merge 3 commits into from
Closed

added more data and infos to Dataset file #31

wants to merge 3 commits into from

Conversation

psytester
Copy link
Contributor

No description provided.

@frankmorgner
Copy link
Owner

please merge this commit with the commit that actually implements NotOnChip

@frankmorgner
Copy link
Owner

you could also set the attribute to '' and filter this in CardGenerator instead of NotOnChip

@psytester
Copy link
Contributor Author

We need that special , because empty string '' is a valid case as well.
On newer cards BirthName data group is personalized, but can be emtpy.

Valid list of "NotOnChip" data groups: ReligiousArtisticName, Nationality, BirthName, ResidencePermit1
@frankmorgner
Copy link
Owner

And NotOnChip is not a valid value? ;-)

What about making the configuration file a real python script and just use None and real strings? This would also allow to use binary data...

@psytester
Copy link
Contributor Author

We keep it simple and per defintion string "" will be used as our identifier ;-)
" and ' are part of valid character set, a config file which needs to enclose strings makes it complicate in other stages.

frankmorgner pushed a commit that referenced this pull request Oct 27, 2014
- changes DG13 into BirthName, DG19 into eAT ResidencePermit1 and DG20
  into eAT ResidencePermit2

- better reading of datasetfile (empty lines are allowed, new line
  character is trimmed from value

- Closes #30 #33 #31
@frankmorgner
Copy link
Owner

closed in 75426ae

@psytester psytester deleted the patch-7 branch January 23, 2015 20:51
@r4dr3fr4d r4dr3fr4d mentioned this pull request Mar 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants