Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow feature query for maximum APDU size #245

Closed
wants to merge 3 commits into from

Conversation

swissbit-csteuer
Copy link
Contributor

If the reader's maximum APDU size (dwMaxAPDUDataSize) cannot be queried the client application must assume that only short APDUs are supported.
Since there is no data size limit for virtual smart card communication dwMaxAPDUDataSize can be set to the maximum APDU size of 65536 (extended APDUs).

If the reader's maximum APDU size (dwMaxAPDUDataSize)
cannot be queried the client application must assume
that only short APDUs are supported.
Since there is no data size limit for virtual smart card communication
dwMaxAPDUDataSize can be set to the maximum APDU size of
65536 (extended APDUs).
Copy link
Owner

@frankmorgner frankmorgner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please import reader.h from ccid-1.3.11 as published by Apple to virtualsmartcard/MacOSX and #include <reader.h> in ifd-vpcd.c instead of copying its contents.

The rest of the changes look good.

@frankmorgner
Copy link
Owner

and please use the curly braces on the same line as the if statement

@swissbit-csteuer
Copy link
Contributor Author

Thanks for reviewing the PR.

please import reader.h from ccid-1.3.11 as published by Apple to virtualsmartcard/MacOSX and #include <reader.h> in ifd-vpcd.c instead of copying its contents.

The rest of the changes look good.

The file from the apple page is a bit dated and does not contain the FEATURE_GET_TLV_PROPERTIES definition. I took the file from the PCSC repository instead and put it into virtualsmartcard/src/pcsclite-vpcd/PCSC/.

and please use the curly braces on the same line as the if statement

done

@frankmorgner
Copy link
Owner

I've merged the changes to master with a minor change in the includes. I've also updated ifdhandler.h in pcsclite-vpcd to 1.9.9 and copied header files from macOS Sierra's CCID driver to virtualsmartcard/MacOSX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants