Convert most of the remaining tests to unit tests #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently include the PBKDF2 implementation from the PyCrypto author. This patch removes some of the stuff we do not use and need. In the future we should move to the PBKDF2 implementation that is nowadays included in PyCrypto to clean up the code even more.
The SE API has changed so that all the old tests will need to be fixed. This is the first step in this direction.
This patch fixes the remaining Security Environment test cases so that they will at least run. This has already turned up some strange/inconsistent behaviour in the Security_Environment class and at least one bug (incorrect usage of the bertlv_pack function in the generate_public_key_pair method).
frankmorgner
pushed a commit
that referenced
this pull request
Aug 2, 2014
Convert most of the remaining tests to unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These patches move the remaining tests from utils.py as well as most of the commented out Security Environment tests to unit tests. The PBKDF2 tests are removed since, this is an external project that we just included verbatim in CryptoUtils.py
The tests have already revealed some strange/incosistent behaviour in the Security_Environment class but this will be fixed later, when there are enough unit tests to be confident that no functionality is broken by the changes. The tests have also uncovered one bug in the generate_public_key_pair method (incorrect usage of the bertlv_pack method), which is also fixed with this pull request.