Use the python unittest framework for vpicc #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why didn't you keep the tests that were commented out? |
|
sorry, I mean: why did you keep the tests that were commented out? |
|
I wanted to build working test cases from the test code that is commented out but the interfaces have changed and I could not yet figure out how to make the code work again. I plan to write more test cases and use the commented out code as a starting point. If you think this code is too old and deprecated as to be useful, I'm okay with throwing it out. |
|
My main motivation for this pull request is the following: I want to do some refactoring of vpicc but I haven't worked with the code for so long, that I will probably break a lot of things in the process. Therefore I want to add unit tests before changing the code. |
frankmorgner
pushed a commit
that referenced
this pull request
Jul 24, 2014
Use the python unittest framework for vpicc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These patches convert the (very few) existing unit tests of vpicc to the unittest framework included in Pythons standard library. The test cases are moved into a dedicated subpackage and executed via TravisCI.