(partially) fix macOS 10.14/Xcode 11.0 compile and install issues #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micolous
changed the title
|
thank you |
bowb
pushed a commit
to bowb/vsmartcard
that referenced
this pull request
Mar 6, 2023
(partially) fix macOS 10.14/Xcode 11.0 compile and install issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes compile errors in
pcsc-relayon macOS 10.14 with Xcode 11.0 toolchain:This is caused by using
--framework PCSCinstead of-framework PCSC.Also fixes an issue with
make installonvirtualsmartcardon macOS 10.11+ (System Integrity Protection). This fix was already in the macOS package installer, but wasn't inconfigure.acsomake installwould fail.I also reversed those changes for
MacOSX/Makefile.am, because then the paths are consistent regardless of whether it was built on macOS 10.11+ or not... but this is still broken with macOS 10.14.This also fixes an error with
--enable-infoplistno longer being an option.I've also removed building for
i386, because this is not supported by Xcode 11, and builds fail without it. Such is the march of progress...