Fix selection by DF name #118
Conversation
DF names shall be globally uniqe within a given card. Selecting by DF name should be made on card level instead of current DF level. A new list has been inroduced as a static attribute of MF in order to track each named DF.
|
Looks OK. Additionally, |
|
In my opinion it is already handled. |
|
I think you're right, but I need to investigate the problem with the unit test (See Travis CI result)... |
|
Well I've investigated Travis log. The test fails because named DFs are tracked in the Consequence: it is not a good approach to track named DFs as a global attribute of Now I'm a little bit confused how to do it. Maybe I could look for the |
Named DFs can't be tracked in the global namespace of MF, because if we do so, it is impossible to generate two different cards with the same content.
By adding a possible self-pointer to MF prettyprint_anything function got into an infinite loop. Printing of named DFs has been cut off.
Change named_dfs attribute to be a class property
|
looks good now, thanks for looking into this. |
DF names shall be globally uniqe within a given card. Selecting by DF name should be made on card level instead of current DF level. A new list has been inroduced as a static attribute of MF in order to track each named DF. * Prevent prettyprint from infinite recursion By adding a possible self-pointer to MF prettyprint_anything function got into an infinite loop. Printing of named DFs has been cut off.
DF names shall be globally uniqe within a given card. Selecting by DF
name should be made on card level instead of current DF level.
A new list has been inroduced as a static attribute of MF in order to
track each named DF.