Fix length of filesize parameter in FCP template #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'Number of data bytes in the file' parameters should be represented on two bytes in FCP.
|
|
|
You might be right. In the first ('95) version of the standard contained fix length of 2 bytes for both tags (http:https://cardwerk.com/smart-card-standard-iso7816-4-section-5-basic-organizations/). I'm using the 2005 version of the standard which still sais 2 bytes for tag 0x81, but allows variable length for tag 0x80. Unfortunately my host-application only supports older versions of the standard. I may override this function on a lower level if you do prefer so. |
|
Maybe you could refactor the patch so that the length takes at least 2 bytes and possibly more. That should be backward compatible. |
Increase length of filesize parameter in FCP template if can't be represented on two bytes.
|
thanks |
suttod
added a commit
to suttod/vsmartcard
that referenced
this pull request
Mar 26, 2020
* Fix length of filesize parameter in FCP template 'Number of data bytes in the file' parameters should be represented on two bytes in FCP. * Extendable length of filesize parameter in FCP Increase length of filesize parameter in FCP template if can't be represented on two bytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'Number of data bytes in the file' parameters should be represented on
two bytes in FCP.