Make the Relay card still parse and log the APDU #103
Conversation
The basic VirtualSmartcard implementation parses and logs the APDU sent to the card in the execute instance method, and logs the received APDU after calling that method. The Relay implementation, however, overrides the execute method, but does not log it. The result, when running at the info log level, is that you see the reply from the card, but not the request from the application. This is confusing. Additionally, if the relay implementation shows the request APDU, then it can be used as a method to analyze what an application is trying to do. To remedy all that, parse the APDU and log that parsed value, but don't do anything further with it. Signed-off-by: Wouter Verhelst <[email protected]>
|
The current behavior is odd, indeed. Thanks for the report! However, logging the APDUs (command/response) should only be done in |
|
Yes, good point. At the same time, often it's helpful to still get a parsed APDU in the log. I'll add a command-line parameter Does that make sense? |
Some unknown cards, which the Relay card may need to deal with, may not use the APDU format. Trying to parse commands sent to those cards as though they were in the APDU format is obviously wrong. However, most cards do support APDU, so default to logging parsed APDUs, still.
|
I've done that, and pushed another commit to this pull request . Please review. |
|
Sorry for the late feedback. I still wonder if we could get around the extra option. Would it be possible to try parsing and printing the APDU and only hexdump the buffer when the parsing fails? |
|
No worries. I suppose that's a good idea too, and shouldn't be too hard. I'll look into it. |
Don't switch to logging unparsed messages upon command line parameters; instead, switch to doing so if parsing fails.
The basic VirtualSmartcard implementation parses and logs the APDU sent
to the card in the execute instance method, and logs the received APDU
after calling that method.
The Relay implementation, however, overrides the execute method, but
does not log it. The result, when running at the info log level, is that
you see the reply from the card, but not the request from the
application. This is confusing.
Additionally, if the relay implementation shows the request APDU, then
it can be used as a method to analyze what an application is trying to
do.
To remedy all that, parse the APDU and log that parsed value, but don't
do anything further with it.
Signed-off-by: Wouter Verhelst [email protected]