Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support enforcing truncate shorthand #255

Merged
merged 1 commit into from
Jun 24, 2023

Conversation

bezbac
Copy link
Contributor

@bezbac bezbac commented Jun 15, 2023

Support enforcing truncate shorthand

Description

This PR aims to enforce that overflow-hidden text-ellipsis whitespace-nowrap can be replaced with the truncate class.

Fixes #253

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I added unit-test cases, which should extensively test the newly introduced code.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@francoismassart
Copy link
Owner

Hi @bezbac,
thank you for your contributions 👏 , sorry about the delay of response, my wife has a disabled arm for few weeks and I've way more daily home tasks to handle 😅
I'll merge it and publish a beta version in order to test it against real world projects.

@francoismassart francoismassart merged commit 8bc2e5c into francoismassart:master Jun 24, 2023
@francoismassart
Copy link
Owner

npm i [email protected]

@francoismassart
Copy link
Owner

I tested it on our main website and it work smoothly. Waiting few days for feedback and I'll be releasing v3.13.0 officially. 😺

@bezbac
Copy link
Contributor Author

bezbac commented Jun 27, 2023

Hi @francoismassart,
Please don't apologize. Thank you for reviewing the PRs and maintaining this library! 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Replace overflow-hidden text-ellipsis whitespace-nowrap with truncate
2 participants