Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeatureFor Blade Directive #9

Conversation

victorlap
Copy link
Contributor

Resubmission of #8.

Description

I have added the @featurefor blade directive, to easily use the isEnabledFor() method.

Motivation and context

This change is to complement the already existing @feature blade directive.

How has this been tested?

I have test this the same way the laravel blade directives are tested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

@francescomalatesta
Copy link
Owner

This is awesome :) just a question: what about adding support for the php artisan feature:scan command?

@victorlap
Copy link
Contributor Author

victorlap commented Apr 17, 2018

Missed that one, will add that function tomorrow

@francescomalatesta
Copy link
Owner

Thank you :D looking forward to merge this one ;)

@victorlap
Copy link
Contributor Author

I have altered the regex, and changed the foreach to make use of collections.

@francescomalatesta
Copy link
Owner

Sorry for the big late, I wasn't around for a while :( thanks for your precious contribution!

@francescomalatesta francescomalatesta merged commit b495a44 into francescomalatesta:master Nov 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants