Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for sous_layout_builder #13

Merged
merged 1 commit into from
May 26, 2024

Conversation

laura-johnson
Copy link
Collaborator

Suggestions:

  1. Add non-plain filter formats to the text fields (possible now with the formats recipe that is included with sous_content_types)
  2. The recipe complained that it was missing dependencies and I added the block_content and options modules as dependencies of the recipe to fix that
  3. Rather than include 3rd party config (the gin_lb.settings.yml in this case) it's preferable to use config actions to set our preferences, see the recipe.yml suggestion

Question - maybe an issue

I don't see the option to edit the layout on the page content type. Shouldn't we see that option? Not sure what is missing here, I checked the settings and I don't see anything obvious but I don't know LB very well...

sous-layout-builder

@laura-johnson laura-johnson changed the title suggestions-for-sous-layout-builder-recipe Suggestions for sous_layout_builder Mar 24, 2024
@laura-johnson laura-johnson mentioned this pull request Mar 24, 2024
14 tasks
@codechefmarc
Copy link

Gotcha, thank you for the review and the suggestions! I'll take a look soon and will let you know.

@laura-johnson laura-johnson merged commit e8d335a into sous-layout-builder-recipe May 26, 2024
@laura-johnson laura-johnson deleted the sous-lb-suggestions branch May 26, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants