Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

Add a better t filter to pattern lab so it plays well with Drupal #56

Merged
merged 1 commit into from
Apr 25, 2017

Conversation

ccjjmartin
Copy link
Collaborator

@ccjjmartin ccjjmartin commented Mar 14, 2017

Purpose:

  • Add a better t filter to pattern lab so it plays well with Drupal

Description:

  • While looking at the pager example I noticed that someone had copied and pasted a Drupal template.
  • I then realized that the t function we were using in Pattern lab didn't support string replacements.
  • Now it does.

NOTE:

Testing:

  • Go to the pager molecule and hover over the page numbers. This fix should now display "Go to page 3" instead of "Go to page @key"

@ccjjmartin ccjjmartin changed the title Add a better t function to pattern lab so it plays well with Drupal Add a better t filter to pattern lab so it plays well with Drupal Mar 14, 2017
@ccjjmartin ccjjmartin self-assigned this Mar 14, 2017
@evanmwillhite evanmwillhite added this to Queue in Development Apr 6, 2017
@evanmwillhite
Copy link
Contributor

@ccjjmartin looks awesome. Thanks! :shipit:

@ccjjmartin ccjjmartin merged commit dd2fe04 into master Apr 25, 2017
@ccjjmartin ccjjmartin deleted the feature/t branch April 25, 2017 20:26
@ccjjmartin
Copy link
Collaborator Author

@evanmwillhite Let's discuss adding other Drupal functions in the next Frontend PG so that they don't cause weird errors like this one did.

@amazingrando amazingrando moved this from Queue to Done in Development May 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants