This repository has been archived by the owner on Mar 31, 2023. It is now read-only.
115: ES6 support, ESLint, Babel 7 Upgrade and Babel Polyfill #322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
115: Add ESlint for JS
This PR changed from addressing merely ESLint to moving to ES6 syntax support for all default code.
Companion PR in Emulsify Gulp fourkitchens/emulsify-gulp#108. Must be merged/deployed at the same time.
Changes/additions:
To Test:
npm link
to test the Emulsify Gulp PR (I couldn't get it to work), make sure you've done that and checked out theeslint-dep
branch there. If it doesn't work for you either, replace^4.0.0
withfourkitchens/emulsify-gulp#eslint-dep
in this line of package.json (please don't commit the change) and runyarn
.yarn start
and ensure there are no errors and that the JS components (accordion, main menu (mobile) and tabs) work correctly in all browsers including IE11