Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

Improved icon components. #253

Merged
merged 4 commits into from
Jun 18, 2018
Merged

Improved icon components. #253

merged 4 commits into from
Jun 18, 2018

Conversation

ModulesUnraveled
Copy link
Contributor

  • Simplifies Drupal/PL icon paths.
  • Fixes PL-specific attach_library function

evanmwillhite
evanmwillhite approved these changes Jun 18, 2018
View reviewed changes
Copy link
Contributor

@evanmwillhite evanmwillhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got a JSON error, but it was just the comma. If you're Ok with that change, ship it.

This is a much better approach. Thank you!

@ModulesUnraveled ModulesUnraveled merged commit 980e249 into develop Jun 18, 2018
@ModulesUnraveled ModulesUnraveled deleted the icons branch June 18, 2018 21:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evanmwillhite evanmwillhite evanmwillhite approved these changes

Assignees
No one assigned
Labels
Status: Passes code review Status: Passes functional review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ModulesUnraveled @evanmwillhite