Complete overhaul of components #150

ModulesUnraveled · 2017-09-28T15:04:43Z

This PR is the base branch that will contain all work on overhauling the default components that will come with Emulsify now that we're building it out to be an "example" theme.

So far, here is what has been done:

Deleted everything, and then built the following from the ground up.

base
- global
  - colors/*
  - fonts/*
  - breakpoints.scss
  - variables.scss
  - mixins.scss
  - base.scss
atoms
- headings/*
- links/*

Note:

Future PRs will be based against this branch so the diff will just show the new stuff

evanmwillhite · 2017-10-12T21:17:12Z

Branch has conflicts and also I'm getting an error when compiling:

configuring pattern lab...
PHP Warning:  file_get_contents(/Users/evanwillhite/Sites/static/emulsify/pattern-lab/source/_patterns/01-atoms/headings/01-heading.twig): failed to open stream: No such file or directory in /Users/evanwillhite/Sites/static/emulsify/pattern-lab/vendor/pattern-lab/core/src/PatternLab/Builder.php on line 264
PHP Warning:  file_get_contents(/Users/evanwillhite/Sites/static/emulsify/pattern-lab/source/_patterns/01-atoms/headings/02-heading.twig): failed to open stream: No such file or directory in /Users/evanwillhite/Sites/static/emulsify/pattern-lab/vendor/pattern-lab/core/src/PatternLab/Builder.php on line 264
PHP Warning:  file_get_contents(/Users/evanwillhite/Sites/static/emulsify/pattern-lab/source/_patterns/01-atoms/headings/03-heading.twig): failed to open stream: No such file or directory in /Users/evanwillhite/Sites/static/emulsify/pattern-lab/vendor/pattern-lab/core/src/PatternLab/Builder.php on line 264
PHP Warning:  file_get_contents(/Users/evanwillhite/Sites/static/emulsify/pattern-lab/source/_patterns/01-atoms/headings/04-heading.twig): failed to open stream: No such file or directory in /Users/evanwillhite/Sites/static/emulsify/pattern-lab/vendor/pattern-lab/core/src/PatternLab/Builder.php on line 264
PHP Warning:  file_get_contents(/Users/evanwillhite/Sites/static/emulsify/pattern-lab/source/_patterns/01-atoms/headings/05-heading.twig): failed to open stream: No such file or directory in /Users/evanwillhite/Sites/static/emulsify/pattern-lab/vendor/pattern-lab/core/src/PatternLab/Builder.php on line 264```

ModulesUnraveled · 2017-10-12T22:04:10Z

I think I know why the errors are showing for you. I’ll take a look at that and the conflicts when I’m back at my computer

ccjjmartin · 2017-10-16T03:30:24Z

components/_patterns/01-atoms/headings/01-heading~title-xl.yml

+heading_level:
+ "1"
+heading_content:
+ "Ithaca College Style Guide"


This should probably be changed to say Emulsify Style Guide along with the other heading levels

amazingrando · 2017-11-10T22:28:37Z

@ModulesUnraveled I've reviewed this branch and merged in develop to take care of the conflicts. I did not run into the issue that @evanmwillhite flagged above. (I ran Emulsify with npm and yarn to cover the bases.)

If you make the header change that @ccjjmartin commented about above we can get this merged.

ModulesUnraveled · 2017-11-10T22:38:44Z

@amazingrando it looks like a couple main menu templates also made their way in. We'll probably want them in eventually, but we don't have the menu component in PL yet, so we shouldn't add the Drupal templates yet.

https://github.com/fourkitchens/emulsify/pull/150/files/257f157cc4474e62cfe94e9a37c1cbcd37134cf3..2ac802a7f7b233f4f7c9f308d027afd6ae47f514

amazingrando · 2017-11-10T23:16:50Z

@ModulesUnraveled You must've reviewed the files in that small window between me pushing the merge and then pushing a clean up to remove those pesky menu files. See
2ac802a

evanmwillhite · 2017-11-11T02:30:24Z

I added a menu component - is that what you’re talking about? If so we need those in there.

amazingrando · 2017-11-13T15:54:14Z

@evanmwillhite @ModulesUnraveled For the purposes of this PR do we need the menu files? Or should that be a separate PR?

amazingrando · 2017-11-13T15:55:55Z

@ModulesUnraveled Would you update the description of this PR to include a checklist of what needs to be done for this branch to be considered complete? (Or link to a relevant issue?) Thanks!

evanmwillhite · 2017-11-13T16:48:27Z

The menu files have already been merged in (you got it in here when you merged in develop). I just want to make sure they don't get removed here.

ModulesUnraveled · 2017-11-13T17:02:53Z

@evanmwillhite @amazingrando Oh man... it looks like a lot of stuff got merged in that shouldn't have. This was supposed to be a ground up rewrite. A very intentional "Here's what we want to keep" PR...

I'd like to revert back to before we merged develop and create individual PRs for each component that should get it (e.g. the menus). I think by merging develop we just included a bunch of stuff that hasn't been thoroughly picked through to validate code quality/convention.

amazingrando · 2017-11-13T17:56:11Z

As we mentioned in an meeting outside of Github, I'll rollback the merge.

amazingrando · 2017-12-12T00:26:15Z

@ModulesUnraveled When you get a chance, can you confirm if this branch is in the state that you'd like it to be in? TY.

Restart: Images

Restart: Lists

evanmwillhite · 2018-05-07T22:48:42Z

Does this need to be closed in favor of smaller PRs?

amazingrando · 2018-05-08T01:09:38Z

@evanmwillhite I vote to close this. Work for this could be its own feature branch that has smaller PRs pulled against it.

ModulesUnraveled · 2018-05-08T12:16:45Z

Yeah, this should probably be closed. :( I took too long to get things going, and now there's too much out-of-date

ModulesUnraveled added 12 commits August 25, 2017 22:00

Deleted Drupal templates

4a77758

Updated colors, and mixins, and removed some unwanted components.

34175e5

Deleted some more default components.

1f0bae1

WIP PL base styles.

6e906e9

Deleted all components.

b4ebf5a

Updated fonts.

bc13214

New colors and fonts.

649e940

Updated variable names in the outer-container mixin.

8479c16

Simplified available grays.

0c3c6c3

Removed duplicate gitignore of bem.function.php.

f1259cf

Renamed/configured the images and colors gulp tasks.

e58acb8

Created basic _heading.twig file.

626c7e8

ModulesUnraveled added the ready for review label Sep 28, 2017

ModulesUnraveled added 5 commits September 28, 2017 14:04

Created initial list-item, ul, ol, and dl components.

619c446

Initial styles for lists.

45080bc

Deleted temporary scss placeholder.

5c5b5af

Created link component.

257f157

Initial iamge component.

6eabeb6

evanmwillhite added Status: In Progress and removed ready for review labels Oct 12, 2017

ccjjmartin reviewed Oct 16, 2017

View reviewed changes

amazingrando force-pushed the components/restart branch from 2ac802a to 257f157 Compare November 15, 2017 16:56

ModulesUnraveled added 4 commits December 13, 2017 16:08

Merge pull request #152 from fourkitchens/restart/images

af6f6b7

Restart: Images

Updated example heading text to be generic.

393142e

Updated yarn.lock.

0f6876b

Merge pull request #151 from fourkitchens/restart/lists

eb0f01a

Restart: Lists

ModulesUnraveled closed this May 8, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Complete overhaul of components #150

Complete overhaul of components #150

ModulesUnraveled commented Sep 28, 2017 •

edited

Loading

evanmwillhite commented Oct 12, 2017

ModulesUnraveled commented Oct 12, 2017

ccjjmartin Oct 16, 2017

amazingrando Nov 10, 2017

amazingrando commented Nov 10, 2017

ModulesUnraveled commented Nov 10, 2017

amazingrando commented Nov 10, 2017

evanmwillhite commented Nov 11, 2017 via email •

edited

Loading

amazingrando commented Nov 13, 2017

amazingrando commented Nov 13, 2017

evanmwillhite commented Nov 13, 2017

ModulesUnraveled commented Nov 13, 2017

amazingrando commented Nov 13, 2017

amazingrando commented Dec 12, 2017

evanmwillhite commented May 7, 2018

amazingrando commented May 8, 2018

ModulesUnraveled commented May 8, 2018

Complete overhaul of components #150

Complete overhaul of components #150

Conversation

ModulesUnraveled commented Sep 28, 2017 • edited Loading

So far, here is what has been done:

Note:

evanmwillhite commented Oct 12, 2017

ModulesUnraveled commented Oct 12, 2017

ccjjmartin Oct 16, 2017

Choose a reason for hiding this comment

amazingrando Nov 10, 2017

Choose a reason for hiding this comment

amazingrando commented Nov 10, 2017

ModulesUnraveled commented Nov 10, 2017

amazingrando commented Nov 10, 2017

evanmwillhite commented Nov 11, 2017 via email • edited Loading

amazingrando commented Nov 13, 2017

amazingrando commented Nov 13, 2017

evanmwillhite commented Nov 13, 2017

ModulesUnraveled commented Nov 13, 2017

amazingrando commented Nov 13, 2017

amazingrando commented Dec 12, 2017

evanmwillhite commented May 7, 2018

amazingrando commented May 8, 2018

ModulesUnraveled commented May 8, 2018

ModulesUnraveled commented Sep 28, 2017 •

edited

Loading

evanmwillhite commented Nov 11, 2017 via email •

edited

Loading