Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add engines: node to package.json #15201

Merged
merged 2 commits into from
Jun 23, 2024
Merged

Conversation

MrVauxs
Copy link
Contributor

@MrVauxs MrVauxs commented Jun 22, 2024

Add a node 20 dependency to the package.json to avoid issues in regards to parsing dice (18-19 said to be broken by Tikael, and node 21 also broke my local build process.)

@MrVauxs MrVauxs changed the title Add node to package Add node to package.json Jun 22, 2024
@CarlosFdez
Copy link
Collaborator

CarlosFdez commented Jun 22, 2024

If we're setting nodes in the package.json, it should be in the engines field. That said I'm using 21.7.2 and its functioning fine. The issue with the dice was because peggy was updated to version 4 but the code wasn't updated to handle the breaking changes.

@MrVauxs
Copy link
Contributor Author

MrVauxs commented Jun 22, 2024

The problem with engines is that its strictly advisory, unless we also add an npmrc file to enforce it.
I can change the PR to fit that format instead, I simply went with the most straightforward npm i node -D solution.

@stwlam
Copy link
Collaborator

stwlam commented Jun 22, 2024

engines, no npmrc

@MrVauxs MrVauxs changed the title Add node to package.json Add engines: node to package.json Jun 23, 2024
@stwlam stwlam merged commit 87624b0 into foundryvtt:master Jun 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants