Fix inconsistent line heights with inline links and content links #15090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosFdez
force-pushed
the
consistent-line-height
branch
from
a508f40
to
16d0ce7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The line height property was actually something we added and removing it gets us closer to core's styling. The reduced padding is unnecessary and I can roll that back but it makes the text more readable I hope with that in play as well. The way premium modules actually fix this is by applying font-size: 0.9em instead, which we can try instead of adjusting padding if you want.
Before:
After:
Its more obvious what's going on if you check the second line on the before. The 4th line wasn't impacted because we never applied the line height to inline roll links.