Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix localized string location for Spell Effect: Fire Shield #15024

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Fix localized string location for Spell Effect: Fire Shield #15024

merged 2 commits into from
Jun 12, 2024

Conversation

simonward
Copy link
Collaborator

No description provided.

@simonward simonward added the pr: data update Updates to existing actors and items label Jun 9, 2024
@stwlam
Copy link
Collaborator

stwlam commented Jun 9, 2024

This looks like less of a fix and more of a move to a needlessly verbose key.

@simonward
Copy link
Collaborator Author

This looks like less of a fix and more of a move to a needlessly verbose key.

Reverted the key name change. However, the main purpose is moving the key from PF2E.FireShield.DefendingAgainstWaterLabel to PF2E.SpecificRule.FireShield.DefendingAgainstWaterLabel.

@TikaelSol TikaelSol merged commit ed4b14c into foundryvtt:master Jun 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: data update Updates to existing actors and items
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@simonward @stwlam @TikaelSol