Update Rule Elements UI setting to manage access by user role #14940
Conversation
jfn4th
force-pushed
the
expand-re-permissions
branch
2 times, most recently
from
eabfe87
to
4b6bac7
Compare
|
The idea mostly looks fine to me, though I don't know if we should assume assistant gm as well. It might also be wise to make the value a number analogous to the values of CONST.USER_ROLES (and see if foundry has localization for those roles) and see if that makes the check any easier. |
|
I'd grouped the GM and Assistant GM together as it's more consistent with the current behavior, though I see what you mean. I suppose I could split it up and still maintain the state of affairs for existing worlds by setting Assistant GM as the minimum in the migration. I'll take another look sometime this week. |
jfn4th
force-pushed
the
expand-re-permissions
branch
from
4b6bac7
to
36b2cdc
Compare
|
Thanks for the suggestions @CarlosFdez. All in. |
| scope: "world", | ||
| config: true, | ||
| default: false, | ||
| type: Boolean, | ||
| default: 4, |
There was a problem hiding this comment.
Wouldn't it make more sense to default to 3 here considering that you migrate "no players access" to "Assistant DM access"? This would also go in line with the Foundry default of Assistant DMs having the same level of permissions as full DMs?
Closes #14203
Allows setting a minimum role for Rule Elements UI access. Choices are Game Master/Assistant GM, Trusted Player, and Player.