Add RegionDocumentPF2e and RegionBehaviorPF2e and implement RegionBehaviorPF2e#isOfType
#14877
Conversation
| @@ -271,9 +270,9 @@ function createEnvironmentRollOptions(actor: ActorPF2e): Record<string, boolean> | |||
| const top = region.elevation.top ?? Infinity; | |||
| if (token.elevation < bottom || token.elevation > top) continue; | |||
|
|
|||
| for (const behavior of region.behaviors.filter((b) => b.type === "pf2eEnvironment")) { | |||
There was a problem hiding this comment.
tbh the reason I'd prefer to filter like this is because I think having separate loops for environment or terrain or whatever we do would be easier to read. The performance impact is just the creation of new arrays, since looping twice with one if per is the same performance impact as looping once with two if statements per.
There was a problem hiding this comment.
Filter is restored but I had to change the RegionBehaviorTypeInstances TParent to always have a Scene because apparently the token parent is narrowed to NonNullable somewhere. Tsc complains that ScenePF2e isn't ScenePF2e | null and I can't find a reason for that.
There was a problem hiding this comment.
I think its because until the next ts version, you have to make all filters into type guards. so filter((b): b is whatever =>. The next TS version will make that unnecessary.
There was a problem hiding this comment.
This is what I get when I don't change the RegionBehaviorTypeInstances and I've already spent an hour before trying to figure out why that happens. 🥲
There was a problem hiding this comment.
But I agree that in TS 5.5 it would probably enough to filter on b.isOfType("pf2eEnvionment"). Can't wait for that release.
There was a problem hiding this comment.
It seems to be because RegionBehaviorTypeInstances's definition uses ScenePF2e and not ScenePF2e | null. Given that it seems possible for scene to be null (such as if the actor isn't currently in a scene), shouldn't that be its type anyways?
There was a problem hiding this comment.
The screenshot happens with RegionBehaviorTypeInstances<TParent extends RegionDocumentPF2e = RegionDocumentPF2e>. Explicitly setting RegionDocumentPF2e<ScenePF2e> fixes it.
…onBehaviorPF2e#isOfType`
In3luki
force-pushed
the
v12-region-subclasses
branch
from
e6c86e3
to
e9c8548
Compare
|
I forgot to mark this as a Draft after waking up. 😨 |
…onBehaviorPF2e#isOfType` (#14877)
…onBehaviorPF2e#isOfType` (#14877)
There might be a better way to do this but it works and nothing blows up.