Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automation for the Mechanical Symbiosis background #14697

Merged

Conversation

LJSmith066
Copy link
Contributor

Added a choice set for all skills other than Arcana, added a toggleable roll option for the +1 circumstance bonus to said skill, and added notes with linked Stunned x conditions for failure and crit failure of checks for selected skill.

@LJSmith066 LJSmith066 changed the title Added automation for the Mechanical Symbiote background Add automation for the Mechanical Symbiote background May 13, 2024
@TikaelSol TikaelSol added the pr: data update Updates to existing actors and items label May 13, 2024
packs/backgrounds/mechanical-symbiosis.json Outdated Show resolved Hide resolved
Comment on lines 132 to 133
"text": "You become @UUID[Compendium.pf2e.conditionitems.Item.Stunned]{Stunned 1}",
"title": "Mechanical Symbiosis (Failure):"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"text": "You become @UUID[Compendium.pf2e.conditionitems.Item.Stunned]{Stunned 1}",
"title": "Mechanical Symbiosis (Failure):"
"text": "PF2E.SpecificRule.MechanicalSymbiosis.FailureNote"

We need to localize this. To do this open up /static/lang/re-en.json and go under SpecificRule. Make a new object for MechanicalSymbiosis (be sure to keep the file alphabetized) and put entries in for the text used in the rules here. We don't need specific titles for these notes though, that can just use the item name as normal.

Copy link
Contributor Author

@LJSmith066 LJSmith066 May 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I'd like to keep labels for is since the majority of the time you're not rolling skill checks against a given DC in Foundry (unless the GM posts literally every skill check DC to chat, which I have never known a GM to do), so both the failure and the critical failure notes will show up regardless of the actual degree of success, which means you get handed "You become Stunned 1" and "You become Stunned 2" without any context - is there any other solution for this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will have a label from the item name automatically, pointing back to the source.

Copy link
Contributor Author

@LJSmith066 LJSmith066 May 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, what I'm saying is that 99% of the time the results will look like this:
image

since normally skill checks will be rolled without a targeted DC, so the check usually won't know whether it's a success/failure, so it prints all notes regardless of success state. At least if failure/success is marked in the notes it'll look like this:
image

so it will at least be obvious what success grade correlates with which effect.

packs/backgrounds/mechanical-symbiosis.json Outdated Show resolved Hide resolved
@LJSmith066 LJSmith066 changed the title Add automation for the Mechanical Symbiote background Add automation for the Mechanical Symbiosis background May 13, 2024
LJSmith066 and others added 2 commits May 14, 2024 01:09
added localisation for mechanical symbiosis automations
@TikaelSol TikaelSol merged commit 7fcfc8a into foundryvtt:master May 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: data update Updates to existing actors and items
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants