Rerender token vision when RBV setting is changed #14676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikolaj-a
pushed a commit
to nikolaj-a/pf2e
that referenced
this pull request
May 26, 2024
CarlosFdez
added a commit
that referenced
this pull request
May 29, 2024
CarlosFdez
added a commit
that referenced
this pull request
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue also exists in v11. requiresReload does not work for any of our split off settings menus, but even then the canvas refresh didn't work because token detection modes weren't reset.
Also sneakily fixes
World Default (undefined)for v12. I haven't dug into why selectOptions was doing that when localizing though.