Fix highlighting for cone and custom circle templates #14649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In3luki
reviewed
May 7, 2024
In3luki
approved these changes
May 7, 2024
5f45c0a
to
de10aaf
Compare
de10aaf
to
ed1080e
Compare
CarlosFdez
added a commit
that referenced
this pull request
May 8, 2024
nikolaj-a
pushed a commit
to nikolaj-a/pf2e
that referenced
this pull request
May 26, 2024
CarlosFdez
added a commit
that referenced
this pull request
May 29, 2024
CarlosFdez
added a commit
that referenced
this pull request
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't fix the templates center-point not snapping properly (which is apparently on purpose for smoother behavior), but it does fix the highlight when placed at a corner for a circle template created directly from canvas controls. It also restores mid edge placements for cones going in a lateral direction.