Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set RecordField as unresolved if anything was unresolved #14179

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

CarlosFdez
Copy link
Collaborator

@CarlosFdez CarlosFdez commented Mar 12, 2024

This causes thrown exceptions in strict mode if any key or value in RecordField has unresolved errors. This causes #13927 to behave correctly, but it is an incredibly fundamental change that may have repercussions to rule elements.

@stwlam stwlam merged commit 52cdd67 into foundryvtt:master Mar 12, 2024
1 check passed
@CarlosFdez CarlosFdez deleted the unresolve-record-field branch March 12, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants