Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show impulse junction note on elemental blast attack roll instead of damage roll #14152

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Show impulse junction note on elemental blast attack roll instead of damage roll #14152

merged 1 commit into from
Mar 12, 2024

Conversation

In3luki
Copy link
Collaborator

@In3luki In3luki commented Mar 10, 2024 •
edited
Loading 

In addition, you gain an impulse junction, a benefit that
occurs when you use an impulse of the chosen element
that takes 2 actions or more.

Currently, when an elemental blast attack misses, there is no roll note shown for the impulse junction effect.

After this PR:
image

@In3luki In3luki added the pr: data update Updates to existing actors and items label Mar 10, 2024
@stwlam stwlam merged commit 1dadb10 into foundryvtt:master Mar 12, 2024
1 check passed
@In3luki In3luki deleted the elemental-blast-notes branch April 26, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stwlam stwlam stwlam left review comments

Assignees
No one assigned
Labels
pr: data update Updates to existing actors and items
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@In3luki @stwlam