Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify action toMessage() and use() methods #13198

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

CarlosFdez
Copy link
Collaborator

getDefaultVariant() is not async, and defaults to "toActionVariant()" anyways.

Copy link
Collaborator

@nikolaj-a nikolaj-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@CarlosFdez CarlosFdez merged commit 30e7f39 into foundryvtt:master Jan 23, 2024
1 check passed
@CarlosFdez CarlosFdez deleted the simplify-base branch January 23, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants