Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for providing a numeric difficulty class parameter on action use #12790

Merged
merged 1 commit into from
Jan 14, 2024

Conversation

nikolaj-a
Copy link
Collaborator

@nikolaj-a nikolaj-a commented Jan 6, 2024

Providing just a number for a check DC is such a common use-case that it warrants direct support, instead of having to wrap it up in an object. The original syntax, as well as a DCSlug, is still a valid value.

Before

game.pf2e.actions.get("climb").use({ difficultyClass: { value: 31 } });

After

game.pf2e.actions.get("climb").use({ difficultyClass: 31 });

@nikolaj-a nikolaj-a force-pushed the numeric-dc-as-action-use-param branch from fd1f39d to 36f9e0f Compare January 6, 2024 10:53
@nikolaj-a nikolaj-a marked this pull request as ready for review January 6, 2024 10:57
@stwlam stwlam merged commit 0a76efe into foundryvtt:master Jan 14, 2024
1 check passed
@nikolaj-a nikolaj-a deleted the numeric-dc-as-action-use-param branch January 14, 2024 20:53
nikolaj-a added a commit to nikolaj-a/pf2e that referenced this pull request Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants