Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add effect for Crimson Shroud AC bonus #12301

Merged
merged 6 commits into from
Jan 28, 2024

Conversation

LebombJames
Copy link
Collaborator

No description provided.

@LebombJames LebombJames added the pr: data update Updates to existing actors and items label Dec 16, 2023
@stwlam
Copy link
Collaborator

stwlam commented Dec 17, 2023

Make this a self-applied effect.

@LebombJames
Copy link
Collaborator Author

Of what action? Crimson Shroud already grants Effect: Crimson Shroud

@stwlam
Copy link
Collaborator

stwlam commented Dec 17, 2023

Eh, not worth making an interact action for it

@LebombJames
Copy link
Collaborator Author

I've got a version granting an action with the AC bonus as a self-applied effect locally. Imo it works a bit smoother. Lmk if you want that instead

},
"traits": {
"value": [
"general",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interact in Foundry has the general trait

packs/actions/swirl-crimson-shroud-interact.json Outdated Show resolved Hide resolved
@TikaelSol TikaelSol merged commit ba4b3d5 into foundryvtt:master Jan 28, 2024
1 check passed
pedrogrullada pushed a commit to pedrogrullada/pf2e that referenced this pull request Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: data update Updates to existing actors and items
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants